All Topics
All Topics
Technology
Technology
Design
Design
Programming
Programming
Science
Science
News
News
Gaming
Gaming
Entertainment
Entertainment
Business
Business
Finance
Finance
Sports
Sports
Health
Health
Food
Food
Travel
Travel
Art
Art
Music
Music
Books
Books
Education
Education
Politics
Politics
Personal
Personal
No algorithm. No AI slop. No ads. Just RSS. Pro-human. Indie writers. Real journalism. Open web. Chronological. Hand toasted.

Why I approve pull requests while leaving non-blocking comments

By

jwworth

1mo ago· 4 min readenOpinion

Summary

The article discusses a practical approach to code review: approving pull requests while simultaneously leaving non-blocking comments (nitpicks, suggestions, questions). The author argues this shows care and thoughtfulness, fosters learning, and surfaces misunderstandings without blocking progress. It's a workflow philosophy aimed at balancing thoroughness with team velocity.

Key quotes

· 3 pulled
if my comments are all nitpicks, suggestions, questions, or non-blocking issues, I leave them and approve the PR at the same time.
Comments show that someone has thought about the problem and the solution, and cares about what's happening to the code.
Occasionally, they offer a chance to learn or to surface misunderstandings, assumptions, or hidden risks.
Snippet from the RSS feed
After reviewing a lot of pull requests, I’ve settled on a simple default: if my comments are all nitpicks, suggestions, questions, or non-blocking issues, I leave them and approve the PR at the same time.

You might also wanna read